Skip to content

feat: Add reject reason #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
andypols wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: Add reject reason #1396

andypols wants to merge 8 commits into from
+577 −102

Conversation

@andypols
Copy link
Contributor

@andypols andypols commented Feb 9, 2026 •
edited by jescalada
Loading

Closes #605.

Summary

Right now, reviewers can reject a push without leaving any context, and push authors can’t tell who rejected it or why. This PR makes rejections explicit by requiring a reason and recording the rejecting reviewer, then surfaces that information in the UI.

UI

  • Adds a rejection modal (modeled after the existing Attestation modal) that requires a reviewer to enter a reason before a rejection can be submitted.
CleanShot 2026-02-09 at 13 18 43@2x
  • Displays rejection details on rejected pushes, including who rejected and why, using an info box pattern consistent with the Attestation UI.
CleanShot 2026-02-09 at 13 23 45@2x
  • Refactors PushDetails by extracting components to reduce complexity and improve readability/maintainability.

Backend

  • Introduces a Rejection type containing reviewer, reason, and timestamp.
  • Persists rejections in the DB layer for both file-based storage and MongoDB.
  • Adds server-side validation to enforce that a rejection reason is provided.
  • Adds unit tests covering the rejection persistence flow.
  • Updates integration tests to include a rejection reason.

@netlify
Copy link

netlify bot commented Feb 9, 2026 •
edited
Loading

✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit e376663
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/6989e0c9d8b4120008b8b1de

@codecov
Copy link

codecov bot commented Feb 9, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 78.78788% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.74%. Comparing base (784bfc4) to head (e376663).

Files with missing lines Patch % Lines
src/service/routes/push.ts 74.07% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1396      +/-   ##
==========================================
+ Coverage   81.34%   81.74%   +0.39%     
==========================================
  Files          65       65              
  Lines        4648     4673      +25     
  Branches      792      800       +8     
==========================================
+ Hits         3781     3820      +39     
+ Misses        852      837      -15     
- Partials       15       16       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jescalada jescalada mentioned this pull request Feb 13, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

A reviewer must provide a reason when rejecting a push 💬

1 participant

@andypols